Refactor UI translation files to use nested keys for DRYness#68285
Open
pranampagi wants to merge 7 commits into
Open
Refactor UI translation files to use nested keys for DRYness#68285pranampagi wants to merge 7 commits into
pranampagi wants to merge 7 commits into
Conversation
This commit modifies the English translation files to utilize the $t() function for nested text references, significantly reducing translation duplication and making the localization files more DRY. Specific changes include: - Establishing base concepts (Dag, Task, Asset, etc.) in `common.json`. - Implementing internal nesting within `common.json` and `admin.json` (for connection, pool, and variable strings). - Implementing cross-namespace nesting (e.g., using `$t(common:dag_one)`) in `dags.json` to prove that base concepts can be centralized and accessed from separate JSON files. This ensures consistency across the UI and reduces the maintenance surface area for translating future languages.
boring-cyborg
Bot
added
area:translations
area:UI
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
pranampagi
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
Author
|
Validation performed:
|
Member
There was a problem hiding this comment.
Thanks @pranampagi
1. Some of these change the rendered casing. Where the original text used a lowercase noun mid-sentence, nesting the title-case key capitalizes it:
connections.testDisabled: "Test connection feature…" → "Test Connection feature…"pools.delete.warning: "the pool … this pool" → "the Pool … this Pool"pools.noPoolsFound: "No pools found" → "No Pools found"variables.import.uploadPlaceholder: "containing variables" → "containing Variables"variables.noRowsMessage: "No variables found" → "No Variables found"
Could we leave those running-text strings un-nested? The nesting is great for labels/buttons/titles (those are title-case already), just not for mid-sentence prose where the noun was lowercase on purpose. Or we accept this difference if we think it's fine.
2. Since this is a values-only change, could you add before/after screenshots of the Connections/Pools/Variables screens (or confirm you checked them)? Just to be sure none of the rendered strings shifted unintentionally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the Airflow UI translation files in the English (
en) locale to utilize the$t()function for nested text references.What and Why:
Previously, core concepts (like "Dag", "Task", "Connection") were repeated verbatim across hundreds of keys. This creates a large maintenance surface area and leaves room for translation inconsistencies across languages.
To make the localization files more DRY (Don't Repeat Yourself), this PR:
common.json.common.jsonandadmin.json(e.g.,"$t(connections.connection_one)").dags.json(e.g.,"$t(common:dag_one)") to prove that base concepts can be centralized and accessed from separate JSON files.Closes: #68252
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.